Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Update golden data for account for the speed regression #825

Merged
merged 1 commit into from
Oct 22, 2021
Merged

[fix] Update golden data for account for the speed regression #825

merged 1 commit into from
Oct 22, 2021

Conversation

anj-s
Copy link
Contributor

@anj-s anj-s commented Oct 22, 2021 •
edited
Loading

What does this PR do?

I updated the golden data for OSS to account for the speed regression seen due to the bumped up PyTorch version to 1.9.

This PR is needed to fix FairScale's main branch.

Opened an issue to track this.

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 22, 2021
@anj-s anj-s requested a review from blefaudeux October 22, 2021 12:05
blefaudeux
blefaudeux reviewed Oct 22, 2021
View reviewed changes
benchmarks/golden_configs/oss_mnist.py
@@ -7,7 +7,7 @@
def get_golden_real_stats():

return {
"reference_speed": 660,
"reference_speed": 578,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ? ah I thought that it was the loss which changed last time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speed as well and it broke main. I don't know why it did not fail the last time around.

@anj-s anj-s requested a review from blefaudeux October 22, 2021 16:21
blefaudeux
blefaudeux approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@blefaudeux blefaudeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but maybe that it could be an incentive to start deprecating it ?

@blefaudeux
Copy link
Contributor

Thanks for the PR @anj-s !

@anj-s anj-s merged commit 35f327f into main Oct 22, 2021
@anj-s anj-s deleted the fix-oss-speed-regression branch October 22, 2021 22:43
vtantia pushed a commit that referenced this pull request Oct 29, 2021
@anj-s @vtantia
modify golden data (#825)
6c400ed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blefaudeux blefaudeux blefaudeux approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anj-s @blefaudeux @facebook-github-bot